Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fix for #92 #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try fix for #92 #93

wants to merge 1 commit into from

Conversation

nojb
Copy link

@nojb nojb commented May 9, 2016

We need to process the ST_FIN packet even if the connection has not been fully established yet.

@nojb
Try fix for #92
a2ca752 
We need to process the ST_FIN packet even if the connection has not been fully established yet.
@ghazel
Copy link
Contributor

ghazel commented Feb 28, 2018 •
edited
Loading

I believe the correct fix would be to consider ST_FIN as connection completion (as well as ST_DATA):

https://github.com/bittorrent/libutp/blob/master/utp_internal.cpp#L2160

if ((pk_flags == ST_DATA || pk_flags == ST_FIN) && conn->state == CS_SYN_RECV) {
	conn->state = CS_CONNECTED;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nojb @ghazel